Replace .sr-only with .visually-hidden, use static Helper.screenReaderOnly class where applicable, fix SpinnerAjax(Button|Link) label rendering #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozkovec
force-pushed
the
wicket-10.x-bootstrap-5.x-spinner
branch
from
0a52cd8
to
b1e3d40
Compare
|
If I remember correctly, in BS5, |
|
Right, I've missed that. I've slightly enlarged scope of this PR, replacing |
vrozkovec
changed the title
martin-g
reviewed
Dec 4, 2023
...rc/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/components/progress/Stack.java
Outdated
Show resolved
Hide resolved
...rc/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/components/progress/Stack.java
Outdated
Show resolved
Hide resolved
|
All done |
martin-g
approved these changes
Dec 5, 2023
|
Thank you, @vrozkovec ! |
|
Should we backport it to wicket-9.x-bootstrap-5.x ? |
yes, please :) |
martin-g
pushed a commit
that referenced
this pull request
Dec 5, 2023
…rOnly class where applicable, fix SpinnerAjax(Button|Link) label rendering (#1010) * Only add class .sr-only when the label is empty - check in onConfigure * Update helper class name for screenReaderOnly content * Replace .sr-only -> .visually-hidden, use static Helper where applicable * rename all references from "srOnly" to "visuallyHidden" for consistency (cherry picked from commit a0c58cf)
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, just calling
setLabel()triggersAttributeModifierthat adds.sr-onlyeven though the label's model may not be empty and in some setups label is not rendered because.sr-onlyclass hides it.With this change, the check is made in
onConfigure, but not very niceget("label")call is used - better way would requireBootstrapAjaxLinkandBootstrapAjaxButtonmethods that return label to beprotectedinstead ofprivate. Or extracting label's id to the constant and making protected that.